37679137528
72%

Ran 07 Oct 2026 08:08PM UTC

Jobs 1

Files 46

Run time 1min

Badge

Embed ▾

Committed 07 Oct 2026 08:03PM UTC coverage: 72.257% (+0.07%) from 72.192%

Build # 37679137528

Build Type

push

github

Committed by

web-flow

Commit Message

fix(manifests): BREAKING CHANGE keep the CRDs on helm uninstall (#4122)

* fix(manifests): keep the CRDs on helm uninstall

Since the CRDs moved from crds/ into templates/crd/ so that helm upgrade
reconciles them (#3655), they are ordinary release resources, and helm
uninstall deletes them. Deleting a CRD garbage-collects every TrainJob,
TrainingRuntime, ClusterTrainingRuntime and OptimizationJob in the cluster,
while the chart README still promises that the CRDs are left in place.

Annotate the chart CRD templates with helm.sh/resource-policy: keep, gated by
a new crds.keep value that defaults to true, in the make manifests step that
already wraps them for crds.enabled, and cover both settings in the chart
unit tests.

Signed-off-by: Vidyansh <ezboi2312@gmail.com>

* fix(manifests): document reinstalling the chart with kept CRDs

Reinstalling with the same release name and namespace adopts the kept
CRDs. A different release name or namespace fails Helm's ownership check,
so document `--take-ownership` (Helm 3.17+) and re-annotating the CRDs,
and how to remove the CRDs with the release via `crds.keep=false`.

Signed-off-by: Vidyansh <ezboi2312@gmail.com>

---------

Signed-off-by: Vidyansh <ezboi2312@gmail.com>

Coverage Stats

3339 of 4621 relevant lines covered (72.26%)

0.84 hits per line

Jobs

ID	Job ID	Ran	Files	Coverage
1	37679137528.1	07 Oct 2026 08:08PM UTC	46	72.26	GitHub Action Run

kubeflow / trainer / 37679137528
72%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 37679137528

kubeflow / trainer / 37679137528 72%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 37679137528

kubeflow / trainer / 37679137528
72%

README BADGES
x