coreui / coreui-pro / 37608933274

96%

main: 94%

push

github

fix(Stepper): finish the stepper when next() is called on the last step (#1585)

* fix(Stepper): finish the stepper when next() is called on the last step

next() on the last step validated the step and stopped, so a wizard driven
by a single Next control could never finish through it. It now calls
finish(), which validates the step and finishes the stepper when it passes.
React already behaved this way; Vue did nothing there and gets the same
change.

* fix(Stepper): mark the stepper finished before the step content collapses

finish() set _isFinished only in the handler that runs after the collapse animation of a .stepper-step-content step, so a second next() or finish() during the animation validated the step again and fired finish.coreui.stepper twice. The flag is now set as soon as the step passes.

* docs(Stepper): give the next() change its own migration entry

The note sat at the end of the form validation section. It now has a Stepper heading and says that next() finishes on the last enabled step, as finish() does.

7276 of 7844 branches covered (92.76%)

Branch coverage included in aggregate %.

2 of 2 new or added lines in 1 file covered. (100.0%)

12609 of 12904 relevant lines covered (97.71%)

1590.55 hits per line