aio-libs / multidict / 37592164981

86%

push

github

Merge the per-class vectorcall slots and expand small helpers (#1725)

<!-- Thank you for your contribution! -->

## What do these changes do?

Collapses the per-class constructor slots in the C extension: one
`multidict_tp_vectorcall` now serves `MultiDict` and `CIMultiDict`, and
one `multidict_proxy_tp_vectorcall` serves both proxy classes. Each
reads `is_ci` from the exact type (`tp == state->CIMultiDictType`),
which is safe because `tp_vectorcall` is never inherited by subclasses.
The ctor's module lookup moved ahead of the argument count check so the
error message can still name the class; the proxy messages use
`tp->tp_name`, which is the same string as before. The proxy vectorcall
and `_multidict_proxy_set_target()` moved into the MultiDictProxy
section.

`_multidict_getone()`, `_multidict_default_or_key_error()` and
`_multidict_resolve_other()` are expanded at their call sites, and
`_dict_first_key()` drops `NOINLINE` (GCC inlines it into the already
out-of-line `_multidict_init_kind.part.0`).

The pure-Python backend is unaffected; this is C only.

## Are there changes in behavior for the user?

No.

## Is it a substantial burden for the maintainers to support this?

No, it removes four wrapper functions and three helpers.

## Related issue number

N/A

## Checklist

- [x] I think the code is well written
- [ ] Unit tests for the changes exist: N/A, refactor covered by the
existing suite
- [ ] Documentation reflects the changes: N/A
- [ ] If you provide code modification, please add yourself to
`CONTRIBUTORS.txt`: N/A
- [x] Add a new news fragment into the `CHANGES/` folder
- [x] `make doc-spelling` passes and any new technical words are added
to `docs/spelling_wordlist.txt`

Drafted with Claude Code (Claude Opus 5.5); reviewed by @asvetlov.

<details>
<summary>Agent run details (optional, for reviewers)</summary>

Tests (`pytest -q --no-cov`): 3.14.7 4089 passed; 3.14.7t 4074 passed;
3.10.17 with `-m "not leaks and not hypothesis and not cap... (continued)

793 of 1586 branches covered (50.0%)

Branch coverage included in aggregate %.

9353 of 10217 relevant lines covered (91.54%)

1.83 hits per line