aio-libs / multidict / 37591946246

86%

push

github

Make md_set_default and _md_set_default_locked plain static functions (#1724)

<!-- Thank you for your contribution! -->

## What do these changes do?

Made `md_set_default()` and `_md_set_default_locked()` plain `static`
functions instead of `ALWAYS_INLINE static inline`. GCC now emits one
out-of-line `md_set_default()` shared by `setdefault()` and
`MultiDict_SetDefault()`, with `_md_set_default_locked()` still inlined
into it as its only caller. This trims `_multidict.c` against the
inlining budget.

The extra call level is measurable on `setdefault()` with a new key
(GIL, 3.14.7, callgrind):

| operation | before | after | delta |
| --- | ---: | ---: | ---: |
| `MultiDict.setdefault(key, v)`, new key | 495.4 | 520.5 | +5.1% |
| `CIMultiDict.setdefault(key, v)`, new key | 568.1 | 591.3 | +4.1% |

No other row moved by 0.5% or more. FT numbers are pending.

## Are there changes in behavior for the user?

No.

## Is it a substantial burden for the maintainers to support this?

No.

## Related issue number

N/A

## Checklist

- [x] I think the code is well written
- [ ] Unit tests for the changes exist: N/A, no behaviour change
- [ ] Documentation reflects the changes: N/A
- [ ] If you provide code modification, please add yourself to
`CONTRIBUTORS.txt`: N/A
- [x] Add a new news fragment into the `CHANGES/` folder
- [x] `make doc-spelling` passes and any new technical words are added
to `docs/spelling_wordlist.txt`

Drafted with Claude Code (Claude Opus 5.5); reviewed by @asvetlov.

<details>
<summary>Agent run details (optional, for reviewers)</summary>

Inlining: `tools/check_inlining.py` with 3.14.7 and 3.14.7t passed (21
and 23 rules).
Perf: `benchmarks/callgrind_driver.py --include-multidict-only`,
`PYTHONHASHSEED=0`, base and new trees in separate staging dirs; GIL
done, FT pending.
Tests: pending at the time of opening (C extension on GIL and FT, pure
Python, 3.10).
Spelling: sphinx `-b spelling` on the docs, no unknown words.
</details>

793 of 1586 branches covered (50.0%)

Branch coverage included in aggregate %.

9353 of 10217 relevant lines covered (91.54%)

1.83 hits per line