hyperledger / fabric-x-common / 37591514910

82%

main: 82%

Build Type

Pull #193

github

Committed by tock-ibm

Commit Message

[policies] Defer signature verification until a principal matches

#### Type of change

- Improvement (improvement to code, performance, etc)
- Test update

#### Description

- Add `SignatureSetToDeferredVerificationIdentities`, which deserializes each signer but leaves the
  signature unchecked, returning identities that verify themselves the first time they satisfy a
  principal and memoize the outcome. `SignatureSetToValidIdentities` is untouched, so no existing
  caller changes behaviour.
- Point `cauthdsl`'s signature policy at it. That is its only caller in this repo, so the change is
  confined to the `EvaluateSignedData` path; `EvaluateIdentities` already forwarded converted
  identities without re-verifying.
- The returned identities no longer imply a checked signature — only a principal check does — and
  they carry the memoized outcome, so they are mutable and not safe for concurrent use. Both are
  documented on the function.
- De-duplication now records a signer before verifying rather than after. A set carrying the same
  signer twice, the first with an invalid signature and the second valid, previously passed on the
  second entry and now fails on the first. It also means repeated copies of one signer's signature
  cost one verification instead of one each, which is what the existing de-duplication comment
  intends but does not currently achieve. The godoc states this, and a test pins it.
- On the 4-organization network #192 measured, one request now costs exactly 1 verification on every
  one of 40 independently built bundles, against a mean of 2.80 and a spread of 1 to 5 before. The
  policy walk itself is unchanged: leaf evaluations still range 1 to 5 over the same bundles, so the
  saving is verifications the walk no longer performs, not a shorter walk.

#### Additional details (Optional)

- Verification moves inside `SatisfiesPrincipal`, which is the only method the compiled leaf calls on
  an identity, and `used[i]` is set only a... (continued)

Pull Request Pull Request #193: [policies] Defer signature verification until a principal matches

Coverage Stats

39 of 39 new or added lines in 2 files covered. (100.0%)

3 existing lines in 2 files now uncovered.

13865 of 16865 relevant lines covered (82.21%)

0.82 hits per line