aio-libs / multidict / 37581993345

86%

push

github

Make the getone, pop and proxy init helpers tail-called functions (#1720)

<!-- Thank you for your contribution! -->

## What do these changes do?

Drops the remaining `inline` and `ALWAYS_INLINE` markers from the
helpers in `_multidict.c`, following #1717 and #1718. As a plain
`static` function, `_multidict_getone()` gets one out-of-line copy that
`getone()`, `__getitem__` and their `MultiDictProxy` copies jump to. GCC
still inlined `_multidict_pop()` into `pop()`/`popone()` and
`_multidict_proxy_init()` into both proxy classes' `__init__()`, so
those two get `NOINLINE` to make the callers tail calls too.
`_seq_first_key()`, `_multidict_resolve_other()` and
`_multidict_default_or_key_error()` stay inlined by GCC's own choice.
`_multidict_proxy_set_target()` is left alone since #1719 covers it.

The pure-Python backend is unaffected; this is C codegen only.

## Are there changes in behavior for the user?

No.

## Is it a substantial burden for the maintainers to support this?

No; it removes forced inlining.

## Related issue number

N/A

## Checklist

- [x] I think the code is well written
- [ ] Unit tests for the changes exist (N/A, no behavior change; the
existing suite covers every touched entry point)
- [x] Documentation reflects the changes (N/A)
- [ ] If you provide code modification, please add yourself to
`CONTRIBUTORS.txt` (N/A)
- [x] Add a new news fragment into the `CHANGES/` folder
- [x] `make doc-spelling` passes and any new technical words are added
to `docs/spelling_wordlist.txt`

Drafted with Claude Code (Claude Opus 5.5); reviewed by @asvetlov.

<details>
<summary>Agent run details (optional, for reviewers)</summary>

Codegen (GCC 15, 3.14.7 and 3.14.7t): `multidict_getone`,
`multidict_mp_subscript`, `multidict_proxy_getone`,
`multidict_proxy_mp_subscript` end in `jmp _multidict_getone`;
`multidict_pop`, `multidict_popone` in `jmp _multidict_pop`;
`multidict_proxy_tp_init`, `cimultidict_proxy_tp_init` in `jmp
_multidict_proxy_init`.
... (continued)

793 of 1586 branches covered (50.0%)

Branch coverage included in aggregate %.

9353 of 10217 relevant lines covered (91.54%)

1.83 hits per line