stacklok / toolhive / 37516136801

71%

Build Type

push

github

Committed by web-flow

Commit Message

Add compare-and-set update for DCR credentials (#6758)

* Add compare-and-set DCR credential update

DCRCredentialStore could only create-if-absent or overwrite-if-present,
so a caller coordinating DCR re-registration across replicas could not
make its overwrite safe against a concurrent writer: a lock holder that
stalls past its lease would clobber a newer row on resume. The check and
the write cannot be made atomic from outside the store because the lock
and row keys hash to different Cluster slots and the row encoding is
unexported.

Implements changes for issue #6757:
- Add UpdateDCRCredentialsIfUnchanged and ErrDCRCredentialsChanged
- Memory: compare and write under the storage mutex
- Redis: single-key WATCH/MULTI comparing decoded stored forms, so it
  is Cluster-safe and tolerant of the stored one-second time precision
- TTL handling matches UpdateDCRCredentialsIfPresent
- Regenerate mocks; add unit and Sentinel integration tests

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* Add start barrier to memory DCR CAS race test

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* Clarify DCR compare-and-set contract

Addresses stacklok/toolhive#6758 review comments:
- MEDIUM types.go (4198367657): document how a decorator with a
  non-reproducible transform supplies the stored form of expected
- LOW redis.go (4198367706): document the retry-exhaustion outcome
- LOW memory.go (4198367719): note new time.Time fields must be
  compared with Equal in dcrCredentialsEqual
- LOW redis.go (4198367731): extend maxDCRClaimRetries comment to
  cover UpdateDCRCredentialsIfUnchanged

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* Cover remaining DCR compare-and-set paths

Addresses stacklok/toolhive#6758 review comments:
- MEDIUM redis_test.go (4198367681): test WATCH retry, retry
  exhaustion, corrupt stored row, and expired-but-present row
- MEDIUM memory_test.go (4198367695): per-field comparison table run
  on both backends, wi... (continued)

Coverage Stats

94 of 107 new or added lines in 4 files covered. (87.85%)

14 existing lines in 4 files now uncovered.

84884 of 119629 relevant lines covered (70.96%)

126.13 hits per line