Chia-Network / chia_rs / 37513087362

83%

push

github

Drop the quote wrapper for INTERNED_GENERATOR (#1522)

* Drop quote wrapper and skip execution for INTERNED_GENERATOR

- build_generator() takes a quote: bool param; when false, emits the
  unquoted spend list ((parent puzzle amount solution) ...) instead of
  (q . (...)). solution_generator_2026() uses quote: false.
- run_block_generator2, get_coinspends_for_trusted_block,
  get_coinspends_with_conditions_for_trusted_block, and
  additions_and_removals skip run_program/check_generator_quote/
  check_generator_node for INTERNED_GENERATOR: they deserialize the
  serde_2026 blob and parse the spend list directly.
- InternedBlockBuilder: drop the now-unneeded top-level quote execution
  cost (block_cost 20 -> 0, WRAPPER_VBYTES 11 -> 5).
- Add comments explaining the outer wrapper enables soft-fork expansion.

Co-authored-by: Cursor <cursoragent@cursor.com>

* Factor out first() from the interned/classic branch in run_block_generator2

Both arms now produce the spend list wrapper; the unwrap to the bare
spend list happens once, after the if. Matches the naming scheme used
by the trusted call sites (spend_list_wrapper -> first() -> all_spends).

Co-authored-by: Cursor <cursoragent@cursor.com>

* Add additions_and_removals interned-path parity test

The interned success path had no additions/removals coverage: existing
tests use classic generators or identity-puzzle spends with empty
solutions (no conditions), and the block-refs rejection test exits
before decoding. Build a spend whose identity puzzle emits CREATE_COIN
with a hint and assert the interned path produces the same additions
(with hint), removals, and coin IDs as the classic path.

Addresses a Copilot review comment on #1522.

Co-authored-by: Cursor <cursoragent@cursor.com>

---------

Co-authored-by: Cursor <cursoragent@cursor.com>

209 of 214 new or added lines in 7 files covered. (97.66%)

16914 of 20491 relevant lines covered (82.54%)

11325034.0 hits per line