Eyevinn / mp4ff / 37489528024

83%

Build Type

push

github

Committed by tobbee

Commit Message

fix(mp4): check in decodeBoxBodySR that every box decoder reads exactly its payload

A container steps to the next box where the previous decoder stopped. The previous commit checked that in the subs, mvhd and tkhd decoders only. On the SliceReader path, a header covering bytes after the fields was still accepted for other boxes, such as mdhd, tfdt, mfhd, trex, vmhd, smhd, mehd, pasp, btrt, prft, cslg and sidx, while the io.Reader path rejected them.

decodeBoxBodySR, which DecodeBoxSR, DecodeFileSR and FragmentDecoder use, now checks the reader error and the bytes read for every box except mdat, and replaces the per-box checkPayloadRead. mdat stays exempt so that a file cut short inside its mdat still decodes, for reading its init part; a new test covers that. The test table adds mdhd and tfdt cases. An interleaved benchmark comparison showed no change beyond noise, and allocations are unchanged. The CHANGELOG entry is shorter.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

Coverage Stats

10 of 10 new or added lines in 4 files covered. (100.0%)

48 existing lines in 7 files now uncovered.

23845 of 28819 relevant lines covered (82.74%)

0.83 hits per line