panates / postgrejs / 37460023112

98%

master: 89%

push

github

test: build the two zone-sensitive date cases from local parts

Both predicates a `Date` parameter is matched against read the local
clock - `TimeType.isType` asks `getFullYear`/`getMonth`/`getDate` for the
epoch day, `DateType.isType` asks `getHours` and the rest for midnight -
and the text a Date goes out as is its local wall clock too. Two tests
named their value as an instant in UTC instead, so what they were really
asserting moved with the zone:

- `new Date('1970-01-01T05:00:00Z')` is 05:00 on the epoch day at UTC and
  expects `time`; at UTC-5 it is local midnight, where `DateType` claims
  it first and the answer is `date`.
- `new Date(Date.UTC(2024, 5, 15))` is the 15th at UTC and is compared
  against `'2024-06-15'::date`; at UTC-5 it is the 14th at 20:00, and the
  date that goes out is the 14th.

Built from local parts now, which is what the neighbouring cases in both
files already do - `new Date(1970, 0, 1)` for the midnight one.

Nothing in `src/` changes: the library reads one clock consistently, and
these were the tests disagreeing with it rather than the other way round.
Checked at UTC, UTC-5, UTC+3, UTC+10 and UTC+14 - 2121 tests in every
one, with the DST-fold case in `timestamptz-binary.spec.ts` self-skipping
where a zone has no repeated hour, which is what it is written to do.

4146 of 4361 branches covered (95.07%)

Branch coverage included in aggregate %.

21867 of 22094 relevant lines covered (98.97%)

1894.42 hits per line