panates / postgrejs / 37458825415

98%

master: 89%

Build Type

push

github

Committed by erayhanoglu

Commit Message

fix: a pre-2000 date was encoded a day late

`date` goes on the wire as a signed day count from 2000-01-01, so every
date before that one is negative - and `Math.trunc` rounds a negative
towards zero, which is towards the epoch. `1999-12-31T22:00Z` under
TZ=UTC went out as day 0, which is 2000-01-01. Silently: a row written,
no error, a day late.

    1999-12-31T22:00:00.000Z    pg 1999-12-31    text 1999-12-31    binary 2000-01-01
    1999-12-31T00:00:00.000Z    pg 1999-12-31    text 1999-12-31    binary 2000-01-01

`Math.floor` instead. The epsilon stays: it is what keeps an exact
midnight from landing a hair under its own day. Nine instants across
three zones (UTC, Europe/Istanbul, America/New_York) now agree between
`pg`, the text path and the binary one, where five, four and five of
them did not.

Older than it looks - the line dates to 58875b3, 2023 - and reachable
until now only by naming `date` or `_date` with BindParam. `11cfb77` put
a Date on that path by default once a statement has earned a name, which
is how CI found it: `43-date-param-reuse.spec.ts` compares what the two
paths store, its data has a 1999 instant in it, and the local clock here
is UTC+3 where the two agree. Under TZ=UTC they do not.

The new unit test takes `utcDates`, so it says the same thing wherever it
runs, and walks every midnight for 800 days either side of the epoch.

Coverage Stats

4147 of 4362 branches covered (95.07%)

Branch coverage included in aggregate %.

8 of 8 new or added lines in 1 file covered. (100.0%)

60 existing lines in 2 files now uncovered.

21867 of 22094 relevant lines covered (98.97%)

1894.4 hits per line