coreui / coreui-pro / 37455511477

96%

main: 94%

push

github

fix(forms): restore validation states of checks, radios, switches and input groups (#1572)

#1332 rewrote the field rules of forms/_validation.scss around the
.form-control-group frame and dropped two parts on the way: the
form-validation-controls include that gave .check, .radio and .switch
their state colours, and the .is-* rule that shows the feedback of an
.input-group control from its .form-field. Since then a checkbox, radio or
switch marked .is-invalid kept its neutral border and label, and an input
group control marked .is-invalid drew a red border with no message, which
is how the Server side example of the validation page rendered. A visual
matrix of these layouts by class path and browser path fails 22 of its 37
cases on v6-dev.

Checks, radios and switches now colour the control through their border
and checked tokens, so a checked control keeps its border on the fill; on
.switch, which is the input itself, the rules sit on the control. The
.form-field around one of them colours its label and shows its feedback
wherever it sits in the field, for example next to the label in
.form-field-content. The field around an input group shows its messages
for a .form-control or .form-select in it, on both paths. That rule keeps
its condition in :where(), like the frame rules, so the success message
stays hidden while a frame inside the input group holds an error, whether
the error comes from a class or from :user-invalid.

The form-validation util links the messages the stylesheet shows for a
control and no others: those of each .form-field around a check, a radio,
a switch, a .form-control or .form-select in an input group inside that
field, or a control placed directly in a frame or in its floating label;
the one after a .form-range only for its .form-range-input. Before, a
control deeper than its frame, a field nested inside an input group, and
any input in a .form-range wrapper had a hidden message read as their
error. A visual spec now checks, f... (continued)

7178 of 7742 branches covered (92.72%)

Branch coverage included in aggregate %.

20 of 20 new or added lines in 1 file covered. (100.0%)

12413 of 12708 relevant lines covered (97.68%)

1585.38 hits per line