aio-libs / multidict / 37438296245

86%

push

github

Move _md_post_update_deleted() and md_update_from_kwnames() out of line (#1693)

<!-- Thank you for your contribution! -->

## What do these changes do?

Marks `_md_post_update_deleted()` and `md_update_from_kwnames()` in
`bulk_update.h` as `NOINLINE`. Each has a single caller and GCC inlined
both. `_md_post_update_deleted()` runs once at the end of each
`update()`, inside the already out-of-line `md_post_update()`;
`md_update_from_kwnames()` runs only when the constructor gets keyword
arguments. Neither is on a per-item path, so the call costs nothing
measurable, and the inlining budget they free lets GCC tighten `d[key] =
v` slightly.

Pure Python has no equivalent.

## Are there changes in behavior for the user?

No.

## Is it a substantial burden for the maintainers to support this?

No.

## Related issue number

N/A

## Checklist

- [x] I think the code is well written
- [ ] Unit tests for the changes exist (N/A, no behavior change)
- [x] Documentation reflects the changes (N/A)
- [ ] If you provide code modification, please add yourself to
`CONTRIBUTORS.txt` (N/A)
- [x] Add a new news fragment into the `CHANGES/` folder
- [x] `make doc-spelling` passes and any new technical words are added
to `docs/spelling_wordlist.txt`

Drafted with Claude Code (Claude Opus 5.5); reviewed by @asvetlov.

<details>
<summary>Agent run details (optional, for reviewers)</summary>

`.text` (GCC 15): GIL 245504 → 245632 (+128 B), FT 251312 → 251696 (+384
B), 3.10 242096 → 242176 (+80 B).

Callgrind: `benchmarks/callgrind_driver.py --include-multidict-only`,
`PYTHONHASHSEED=0`, equal-length trees and venvs, 3.14.7 and 3.14.7t.
Every C row is within ±0.1% except:

| op | GIL | FT |
| --- | --- | --- |
| MultiDict `d[key] = v`, existing key | 0 | 446.4 → −4.0 (−0.9%) |
| MultiDict `d[istr] = v` | 856.0 → −1.9 (−0.2%) | 985.9 → −3.6 (−0.4%)
|

`update` and the constructor rows are flat.

Tests: `pytest -q` on 3.14.7 (4089 passed), 3.14.7t (4074 passed),
3.10.17 (4093 pas... (continued)

793 of 1586 branches covered (50.0%)

Branch coverage included in aggregate %.

9353 of 10217 relevant lines covered (91.54%)

1.83 hits per line