coreui / coreui-pro / 37428438804

96%

main: 94%

Build Type

push

github

Committed by web-flow

Commit Message

fix(MultiSelect): hand validation focus and state to the visible control (#1571)

The native select stays in the page as an aria-hidden overlay, so a screen
reader met nothing when validation or a click on its label focused it, and
an aria-invalid or aria-describedby set on it never reached the control
people hear. The select now passes any focus on to the control (the search
box when search is on); the browser's validation bubble still shows over
the field after a submit and after reportValidity(), checked by hand in
Chrome, Safari and Firefox. The select's aria-invalid, .is-invalid and
aria-describedby, and the invalid option, are carried to that control as
they change, and a selection change fires input and change on the select
as a native list does, so a stepper or the docs' validation script clears
the error it set there.

The change grows the JS bundles by 232 to 268 B gzipped; the six
bundlewatch ceilings go up by 0.25 to 0.5 kB.

Coverage Stats

7095 of 7657 branches covered (92.66%)

Branch coverage included in aggregate %.

26 of 26 new or added lines in 1 file covered. (100.0%)

2 existing lines in 1 file now uncovered.

12290 of 12586 relevant lines covered (97.65%)

1599.55 hits per line