bitshifter / glam-rs / 37427032016

99%

Build Type

push

github

Committed by web-flow

Commit Message

fix(rust-gpu): remove Vec3A special casing (#898)

Related rust-gpu PRs: https://github.com/Rust-GPU/rust-gpu/pull/660
https://github.com/Rust-GPU/rust-gpu/pull/661

# Objective

**Main change: don't special case `Vec3A` as a rust-gpu SPIR-V vector**
* changes it's SPIR-V representation from `OpTypeVector %f32 3` to
`OpTypeStruct %f32 %f32 %f32 %f32`
* this makes `Vec3A` incompatible with certain SPIR-V intrinsics 
* rust-gpu removes it's `unsafe impl Vector for Vec3A` to disallow it's
use
* Migration: use `Vec3` instead and convert back and forward with
`Vec3::to_vec3a()` and `Vec3A::to_vec3()`
* as it's no longer special cased, glam can add back the `_w: f32`
member and derive `Pod` and such
* so we can revert the hack from
https://github.com/bitshifter/glam-rs/pull/861
  
Best reviewed commit by commit, as the first commit is just a revert
(that needed a little manual conflict resolution) and the second commit
is the actual 3 line change.

**I would like this change to be released as a minor patch like
v0.34.1**. Upgrading from 0.34.0 to 0.34.1 is *technically* a breaking
change for any rust-gpu user, but rust-gpu doesn't support glam 0.34.0
yet. So when I do add support for 0.34, I can just require at least
version 0.34.1 to mitigate it.

To prevent future breakages: Changing the members of a struct annotated
with `#[rust_gpu::vector::v1]` is considered a breaking change for
rust-gpu, even if they're just private. When I added those annotations,
I assumed that'll basically never happen, but
https://github.com/bitshifter/glam-rs/pull/786 changed `Vec3A` to have a
private `_w: f32` member.

## Checklist

- [ ] `cargo run -p ci` passes.
- [ ] PR title follows [Conventional
Commits](CONTRIBUTING.md#pull-request-titles); mark breaking changes
with `!`.

Coverage Stats

1 of 1 new or added line in 1 file covered. (100.0%)

95 existing lines in 22 files now uncovered.

91741 of 92642 relevant lines covered (99.03%)

118725.6 hits per line