umputun / agterm / 37405685665

94%

push

github

Attach Remote from the File menu with remotes.conf (#710)

* feat(remotes): parse remotes.conf

One remote per line, destination then an optional label. The destination passes the same rule the ssh argv builders apply, so a listed entry is never refused later as an invalid host. Adds the config path, a commented starter and the implementation plan.

* feat(menu): attach a remote session from the File menu

File > Attach Remote lists the machines in remotes.conf and is disabled when it lists none. Picking one shows that machine's sessions in the picker and attaches the chosen one in the window the action started in. A HUD over the starting session shows the two ssh waits and a failure, which hides itself after five seconds. A watcher follows the file, so an edit shows without a reload.

* feat(menu): choose the remote in the picker and add attach_remote

File > Attach Remote… is one item: with several remotes it asks which in the picker, with one it lists that machine directly. The attach stays in the window it started in. attach_remote is a built-in keymap action on Cmd-Shift-A with a command palette row; a keymap already using that chord keeps it.

* fix(keymap): ship attach_remote on Cmd-Shift-R

Cmd-Shift-A is the default key of Terminal.app's Search man Page Index service, which every app offers while text is selected. Notes in the keymap rules that a new default has to be checked against macOS Services.

* fix(sidebar): redraw a remote row when its connection state changes

The connection state lives in a property observers are not told about, so a row attached while connecting kept the disconnected cloud until something else redrew the sidebar. Session.remoteConnection now announces a change, and the sidebar reads it.

* fix(remotes): report a broken remotes.conf and follow a symlinked one

An edit that turns a clean file into one with unusable lines, or an unreadable file, is reported once by a notification, and a file already broken is reporte... (continued)

87 of 87 new or added lines in 10 files covered. (100.0%)

15165 of 16168 relevant lines covered (93.8%)

2524030.8 hits per line