solidjs / solid / 37387555951

76%

main: 89%

push

github

fix(signals): a retained projection draft row resolves to its store proxy (#3767) (#3807)

* fix(signals): a retained projection draft row resolves to its store proxy (#3767)

A derived store whose derive returns rows from its own draft
(`draft => [...source(), ...draft.filter(r => r.failed)]`) puts the draft
wrapper itself into the result. On the next source refresh reconcile's
descend unwrapped the wrapper to itself and adopted it as the row's own
backing, so every read of the row forwarded to itself until the stack
overflowed.

`wrapDraft` now registers the wrapper as its store target's alias in the
family map (or the global lookup), so `wrap`, `unwrapValue` and reconcile's
slot matching all resolve it to the store proxy: the row keeps its
identity, writes through the setter land, and an equivalent refresh no
longer re-runs readers of the retained row.

Size-Exception: +20 B on `signals: + createStore` (14.56 -> 14.58 KB) and
the frozen `page: live server components` cap (48.51 -> 48.53 KB), accepted
by the maintainer for #3767.

Co-authored-by: Nick <rudbsm@gmail.com>
Co-authored-by: Cursor <cursoragent@cursor.com>

* fix(signals): register the #3767 draft alias through a shared setLookup helper; drop the cap raises

createTarget, adoptPB and wrapDraft share one lookup-registration helper;
brotli is roughly neutral, so every scenario fits its existing cap.

Co-authored-by: Nick <rudbsm@gmail.com>
Co-authored-by: Cursor <cursoragent@cursor.com>

---------

Co-authored-by: Nick <rudbsm@gmail.com>
Co-authored-by: Cursor <cursoragent@cursor.com>

649 of 925 branches covered (70.16%)

Branch coverage included in aggregate %.

962 of 1195 relevant lines covered (80.5%)

27.82 hits per line