solidjs / solid / 37338342306

76%

main: 89%

push

github

fix(signals): two crash-class bugs from the semantic fuzzer — a lane node in a held frame stays the lane's; a verdict reader revealing an orphan flight holds it (#3798)

* fix(signals): a lane's node inside a held frame stays the lane's (fuzzer F7a/F7b)

`holdFrame` holds a parked pass's frame with the transaction (ruling A).
It re-listed a lane's node found there — a verdict reader created in
the frame, broken out into the holder's verdict lane (display-ahead,
L2 rule 6), or a derivation of a guess — on the frame's transaction,
still carrying its lane value (CONFIG_OVERRIDE). At the landing
`dissolveLane` no longer found the node (its `_transaction` was the
transaction's) and `land` nulled the transaction: a lane node with no
lane, and the landing's re-derivation tripped over it (`laneRead` →
`txOf(null)` → TypeError, REACTIVITY_HALTED).

The shapes: a `Loading` whose content reads `latest(x)`, unmounted and
remounted while `x` is held by an action (F7a); a memo of
`isPending(() => x())` mounted in the tick of the write it probes, its
mount toggled off and on while the write is held (F7b). The remounting
gate's write joins the hold (A34 (1)), so its new frame is held with it
— and the verdict-lane nodes inside it were taken along.

`holdFrame` now skips a child listed on a lane, as the seam's own hold
loop already does for this flush's stagings: lane work never makes its
node transaction work (A15, #3698), and a lane pass's frame is the
lane's, revealed and retired at its seam. The lane's end (`dissolveLane`
at the parent's landing) commits the node as before. Every other
`holdNode` site (the seam loop, the store's three) already excluded
lane work; this was the one that did not.

F7a and F7b flip from `it.fails` to `it`. No other pin moved.

Co-authored-by: Claude via Cursor <noreply@cursor.com>

* fix(signals): a verdict reader revealing a flight nobody holds registers it with the frame (fuzzer F12)

A verdict reader (`latest`/`isPending` in its pa... (continued)

649 of 925 branches covered (70.16%)

Branch coverage included in aggregate %.

962 of 1195 relevant lines covered (80.5%)

27.78 hits per line