solidjs / solid / 37287144634

76%

main: 89%

push

github

fix(ssr): the end of a streamed render waits for a suspended shell (#3771)

flushEnd flushed the serializer whenever the fragment registry was
empty. A <Loading> fragment settling while the shell was still suspended
(a lazy memo throwing NotReadyError above it, the router's flash-decode
shape) emptied the registry before the root holes re-pulled, so the
flush ran first. Seroval drops writes after flush and fires onDone once:

- everything the re-pull serialized was missing from the hydration data,
  in both the piped and awaited forms;
- the awaited form (renderToStream(...).then) completed with an empty
  document — onDone's doShell() bailed on the pending holes and
  completion ran anyway;
- with an <Errored> holding the suspended subtree, the render never
  completed.

Pending root holes now gate flushEnd. Both consumers' flush loops call
it again once the holes resolve. (The serializeRootAssets guard was an
earlier patch for one symptom of the same race.)

Co-authored-by: Claude via Cursor <noreply@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>

649 of 925 branches covered (70.16%)

Branch coverage included in aggregate %.

962 of 1195 relevant lines covered (80.5%)

27.77 hits per line