supabase / supabase-flutter / 37326960775

92%

push

github

fix(typegen): suffix members named like a core type so the generated code compiles (#1914)

## Summary

A column, computed field or relation named `int`, `double`, `num` or
`bool` makes `supabase_typegen` emit code that does not compile. The
member takes the name unchanged, and inside the row type and the
namespace class it shadows the core type every sibling member is typed
with.

A table with `num int4` and `price numeric` is enough:

```dart
extension type const ReadingsRow(Map<String, dynamic> _json) implements Object {
  int get num => _json['num'] as int;
  num get price => _json['price'] as num;
}

class Readings {
  static const num = PostgrestColumn<ReadingsRow, int>('num');
  static const price = PostgrestColumn<ReadingsRow, num>('price');
}
```

```
error - Undefined class 'num'. - undefined_class
error - The name 'num' isn't a type, so it can't be used in an 'as' expression. - cast_to_non_type
error - The name 'num' isn't a type, so it can't be used as a type argument. - non_type_as_type_argument
```

A `num` column next to any `float8` column fails the same way, because
the floating conversion is `(_json['ratio'] as num).toDouble()`.

The top level `_TypeNameRegistry` already reserves these four names, but
member names never went through it. This reserves them where members are
claimed, the same way `toJson`, `postgrestBytea` and `postgrestVector`
are:

- the row members, which the column constants and the insert and update
parameters reuse
- the computed field constants
- the relation members, for foreign keys and computed relationships

| Schema object | Before | After |
| -- | -- | -- |
| column `num` | `int get num`, `static const num` | `int get num$`,
`static const num$` |
| computed field `bool` | `static const bool` | `static const bool$` |
| computed relationship `double` | `static const double` | `static const
double$` |
| column `string`, `object`, `list`, `date_time` | unchanged | unchanged
|

Only these four can collide. Memb... (continued)

6 of 6 new or added lines in 1 file covered. (100.0%)

9270 of 10137 relevant lines covered (91.45%)

5.14 hits per line