supabase / supabase-flutter / 37325589602

92%

push

github

fix(postgrest)!: order() no longer forces NULLS LAST by default (#1912)

## Summary

The untyped `PostgrestTransformBuilder.order()` defaulted `nullsFirst`
to `false` and always appended a null placement, so `.order('a',
ascending: false)` sent `order=a.desc.nullslast`. That overrides
PostgreSQL's default for a descending sort, which is `NULLS FIRST`, and
differs from the typed `PostgrestOrdering`, which only sends what was
asked for.

- `nullsFirst` is now a `bool?` that defaults to `null`. When it is left
out no `nullsfirst`/`nullslast` token is sent and the database default
applies.
- `nullsFirst: true` and `nullsFirst: false` still send `nullsfirst` and
`nullslast` respectively.
- Added a `MIGRATION.md` section under v3, listed it under "Changes the
compiler will not catch", and updated the typed table comparison
paragraph that described the old behaviour.

Swift equivalent: supabase/supabase-swift#1417

## Test plan

- [x] `packages/postgrest`: `order_default_test.dart` updated for the
new default and gains a `nullsFirst: false` case;
`insert_builder_test.dart`, `table_executor_test.dart`,
`typed_query_test.dart` pass
- [x] `packages/supabase`: `mock_test.dart` stub URLs updated and
passing
- [x] `dart analyze` and `dcm analyze` clean on both packages

Closes SDK-2122

<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->

## Summary by CodeRabbit

* **Behavior Changes**
* Ordering no longer adds a null-placement option by default.
PostgreSQL’s default null ordering now applies.
  * You can explicitly choose nulls first or last when ordering results.

<!-- end of auto-generated comment: release notes by coderabbit.ai -->

3 of 3 new or added lines in 1 file covered. (100.0%)

9265 of 10132 relevant lines covered (91.44%)

5.14 hits per line