GEWIS / sudosos / 37324352813

88%

push

github

Simplify PDF service abstraction (#161)

* refactor: simplify pdf service abstraction

Replace the PdfAble mixins and the BaseHtmlPdfService hierarchy with
PdfService and StoredPdfService. Entities no longer build a PDF service
per loaded row; controllers call the services directly.

Stored PDFs are now frozen once issued and only re-rendered with
?force=true. Each StoredPdfService declares followsData: write-offs and
payout requests are frozen, so renaming a user no longer rewrites them.
Invoices follow their parameter hash, which catches edits made in the
same PATCH that marks them PAID and stops changing once they are PAID
or DELETED. Seller payouts follow the live sales report. The dashboard's
invoice "Recompile" button now sends force=true.

PdfCompiler shares one lazily created pdf-compiler client per process;
the client holds no per-request state.

Closes #141

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* fix: make invoice state checks agree on the latest status

isState sorted by createdAt only, while getLatestInvoiceStatus also
breaks ties on id and sorted the status list in place. When two statuses
shared a timestamp, calling both on the same invoice could disagree, so a
deleted invoice could read as CREATED. isState and the invoice request
validators now use getLatestInvoiceStatus, which no longer mutates the
list.

The payout request status filter had the same MAX(createdAt) tie, so it
now picks the latest status by createdAt and id, like invoices do.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* docs: use better-sqlite3 in the single-file test command

TYPEORM_CONNECTION=sqlite is no longer a valid driver and throws on startup.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

---------

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>

4572 of 5174 branches covered (88.36%)

Branch coverage included in aggregate %.

150 of 152 new or added lines in 34 files covered. (98.68%)

22824 of 24461 relevant lines covered (93.31%)

809.02 hits per line