GEWIS / sudosos

92%

push

github

fix: pin many-to-many inverse FK cascade behavior explicitly

TypeORM 1.1.1 changes the default cascade action for many-to-many
junction table foreign keys. Before, the inverse-side FK fell back to
NO ACTION whenever the inverse relation didn't set onDelete/onUpdate,
while the owning side always got CASCADE. The new version defaults
both sides to CASCADE, which no longer matches what our existing
migrations already put in the database (NO ACTION).

Set onDelete/onUpdate to NO ACTION explicitly on the two affected
inverse relations so the entity metadata matches the actual schema no
matter which TypeORM default is in effect.

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>

4447 of 5059 branches covered (87.9%)

Branch coverage included in aggregate %.

6 of 6 new or added lines in 2 files covered. (100.0%)

22646 of 24326 relevant lines covered (93.09%)

824.01 hits per line