supabase / supabase-swift / 37321839199

95%

Build Type

push

github

Committed by web-flow

Commit Message

chore!: enable NonisolatedNonsendingByDefault for every SDK target (#1429)

* chore!: enable NonisolatedNonsendingByDefault for every SDK target

Turn on SE-0461 for every target in both manifests, so nonisolated async
SDK functions run on the caller's executor. This changes runtime isolation
and ABI of public async APIs, so it lands in the v3 major.

- ClientMiddleware.intercept spells `next` as nonisolated(nonsending), so
  its type no longer depends on the conforming module's flags.
- HTTPBody.Iterator.next() and withTimeout's operation stay @concurrent.
- Drop the unused TaskLocal.withValue(merging:) helper and trace's
  redundant isolation parameter.
- TestHelpers: match TestScoping's @concurrent closure; collect() stays
  @concurrent.

BREAKING CHANGE: SDK async functions now run on the caller's executor, and
ClientMiddleware conformances in modules without the flag must spell `next`
as nonisolated(nonsending). See V3_MIGRATION.md.

Fixes SDK-2093

* fix(examples): mark Clerk client nonisolated to avoid actor isolation conflict

SWIFT_DEFAULT_ACTOR_ISOLATION=MainActor in the Examples target infers
`thirdPartyAuthWithClerk` as @MainActor, which under SE-0411 requires its
default arguments to also be MainActor-isolated. But Supabase's inits are
nonisolated by default now that NonisolatedNonsendingByDefault is enabled,
so the compiler rejects the mismatch. The client itself is Sendable and
doesn't need MainActor, so mark it nonisolated explicitly.

* fix(examples): mark SupabaseConfig nonisolated to fix actor isolation conflict

SupabaseConfig's static subscript had no explicit isolation, so the Examples
target's SWIFT_DEFAULT_ACTOR_ISOLATION=MainActor made it @MainActor-isolated
by inference. thirdPartyAuthWithClerk's initializer calls it synchronously for
supabaseURL/supabaseKey while SupabaseClientOptions.AuthOptions.init's default
arguments (storageKey, flowType, etc.) are nonisolated per the Supabase
package's now-enabled NonisolatedNonsending... (continued)

Coverage Stats

2 of 2 new or added lines in 2 files covered. (100.0%)

5 existing lines in 2 files now uncovered.

10727 of 11914 relevant lines covered (90.04%)

109.19 hits per line