Eyevinn / hi264 / 37318586980

88%

push

github

chore: require mp4ff v0.58.0 for hardened AVC parameter parsing

mp4ff v0.58.0 (Eyevinn/mp4ff#607, #623) rejects out-of-range SPS, PPS and
slice header values and truncated slice headers, and no longer hangs on a
huge num_ref_idx_l0_active_minus1 or VUI HRD cpb_cnt_minus1. Such streams
now fail with a parse error in hi264, instead of hanging, overflowing
mbWidth*mbHeight, or indexing the dequantization tables with a negative
slice QP.

The hi264dec NALU listing discarded the parse errors, so a rejected SPS,
PPS or slice header silently vanished from its output. It now prints
them. It also indexed nalu[0] without a length check, and panicked on the
empty NAL unit that adjacent start codes (00 00 01 00 00 01) produce;
TestDecodeInfoMalformedNALUs covers both.

Verified with go test ./... (including the golden FFmpeg checksums),
tools/verify_hi264gen.sh (12/12) and tools/verify_pskip_extend.sh (5/5).

28 of 32 new or added lines in 1 file covered. (87.5%)

8165 of 9307 relevant lines covered (87.73%)

1.01 hits per line