#20499
89%

Ran 05 Oct 2026 10:51AM UTC

Jobs 1

Files 697

Run time 2min

Badge

Embed ▾

Committed 05 Oct 2026 10:38AM UTC coverage: 89.356% (+0.03%) from 89.331%

Build # #20499

Build Type

push

github

Committed by

web-flow

Commit Message

okhttp: Set socket read timeout during TLS handshake (#13081)

In `OkHttpClientTransport`, direct TLS connection setup calls
`OkHttpTlsUpgrader.upgrade(...)` without configuring a socket read
timeout (`setSoTimeout`). When a middlebox or unresponsive server
completes the TCP three-way handshake and acknowledges the TLS
`ClientHello` without sending a `ServerHello` or `RST`,
`sslSocket.startHandshake()` blocks indefinitely in socket read. Because
`this.socket` and `asyncSink` are only assigned after
`OkHttpTlsUpgrader.upgrade(...)` returns, channel shutdown cannot close
the underlying socket either, leaving the subchannel permanently stuck
in `CONNECTING`. Configure `sock.setSoTimeout(proxySocketTimeout)`
before `OkHttpTlsUpgrader.upgrade(...)` and reset it to `0` once the TLS
upgrade completes, matching the timeout handling in
`createHttpProxySocket`. Also close `sock` via
`GrpcUtil.closeQuietly(sock)` in `catch (Exception e)` so the socket is
not leaked when handshake setup fails before
`asyncSink.becomeConnected(...)` takes ownership.

Coverage Stats

39256 of 43932 relevant lines covered (89.36%)

0.89 hits per line

Coverage Regressions

Lines	Coverage	∆	File
28	93.24	0.03%	../okhttp/src/main/java/io/grpc/okhttp/OkHttpClientTransport.java
3	74.14	-2.59%	../servlet/src/main/java/io/grpc/servlet/ServletServerStream.java
2	90.63	-0.69%	../core/src/main/java/io/grpc/internal/DelayedClientCall.java
1	93.83	-0.62%	../opentelemetry/src/main/java/io/grpc/opentelemetry/OpenTelemetryMetricSink.java

Jobs

ID	Job ID	Ran	Files	Coverage
1	#20499.1	05 Oct 2026 10:51AM UTC	697	89.36

grpc / grpc-java / #20499
89%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Coverage Regressions

Jobs

Source Files on build #20499

grpc / grpc-java / #20499 89%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Coverage Regressions

Jobs

Source Files on build #20499

grpc / grpc-java / #20499
89%

README BADGES
x