kontron / python-ipmi / 37296521262

94%

push

github

ipmitool.py: fix sdr show for records without ID string

'sdr show' and 'sdr showall' accessed device_id_string and entity_id
unconditionally and failed with an AttributeError on records that have
no ID string, e.g. the management controller confirmation record
(0x13), OEM records (0xc0) or unsupported record types. Only print
these fields if the record provides them and print the decoded fields
of the management controller confirmation record.

Also fix the decoding of the confirmation record: byte 8 contains the
channel number in bits [7:4] and the device revision in bits [3:0],
and bit 7 of the firmware revision 1 is reserved.

Fixes #116.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Signed-off-by: Heiko Thiery <heiko.thiery@gmail.com>

17 of 17 new or added lines in 2 files covered. (100.0%)

5768 of 7467 relevant lines covered (77.25%)

4.63 hits per line