bodgit / sevenzip / 37242725101

76%

main: 78%

Build Type

Pull #497

github

Committed by bodgit

Commit Message

fix: validate file and stream counts in header

readHeader mapped each non-empty file to a stream with
FileFolderAndSize without checking the header was consistent, so a
crafted header could panic NewReader:

* files with streams but no unpack info (nil pointer dereference)
* files with streams but no streams info at all (nil pointer
  dereference in init)
* more non-empty files than substreams (index out of range)
* a folder with multiple substreams but no sizes (index out of range)

Require the number of non-empty files to match the number of streams,
as 7-Zip does, and require substream sizes when any folder has more
than one stream.

Also fix FileFolderAndSize mapping every file to folder 0 when there
is no substreams info; each folder holds exactly one file in that case.

Fixes #491

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

Pull Request Pull Request #497: fix: validate file and stream counts in header

Coverage Stats

30 of 30 new or added lines in 2 files covered. (100.0%)

33 existing lines in 1 file now uncovered.

1902 of 2512 relevant lines covered (75.72%)

0.85 hits per line