coreui / coreui-pro / 37236633474

96%

main: 94%

push

github

fix(ChipSet): keep focus in the set when its last chip is removed (#1563)

* fix(ChipSet): keep focus in the set when its last chip is removed

Removing the focused chip moved focus to a neighbouring chip, and when
there was none it fell to the body, where Chrome with VoiceOver drops
the removal announcement. Focus now moves to the set itself, which gets
tabindex="-1" until focus leaves it (dispose() gives it back, and a
tabindex the page set is left alone).

Focus only moves when the removed chip held it, or nothing did, so
remove() called from elsewhere on the page no longer pulls focus onto a
neighbouring chip, or in ChipInput into the text field.

* chore: raise four bundlewatch ceilings for the chip set focus fix

Keeping focus in the set adds 137 B to coreui.esm.min.js, 205 B to
coreui.js, 139 B to coreui.min.js and 136 B to coreui.bundle.min.js
(gzip -9 against v6-dev at 3b3f9076). The first two go over their
ceilings and the other two are left with 0 and 10 B, so all four go
up by 0.25 kB.

* fix(ChipSet): move focus only when the removed chip holds it

The check now reads the active element of the chip's own root, so a set
inside a shadow root moves focus to the neighbouring chip again, and a
focused remove button counts as the chip holding focus. A removal while
nothing has focus leaves focus alone instead of pulling it into the set.

The set's tabindex="-1" stays while the set still has focus (switching
windows fires blur without moving focus) and goes at once when focus()
does not take. A focused set shows the focus ring the chips use. The
Chip and Chip set pages say that focus goes to the set once no enabled
chip is left.

6933 of 7488 branches covered (92.59%)

Branch coverage included in aggregate %.

24 of 24 new or added lines in 2 files covered. (100.0%)

12089 of 12382 relevant lines covered (97.63%)

1484.34 hits per line