romshark / datapages / 37234184750

44%

Build Type

push

github

Committed by romshark

Commit Message

fix: End natscore streams on NATS connection close

The natscore broker keeps a subscription channel open after the NATS
connection closes, which nats.go does once its reconnect attempts run
out: 60 attempts 2s apart by default.

    nc, _ := nats.Connect(url, nats.MaxReconnects(1))
    sub, _ := natscore.New(nc, natscore.Config{}).
        Subscribe(ctx, messaging.NoopMetrics{}, "chat.room")
    // Stop the NATS server. nats.go fails to reconnect once
    // and closes nc.
    for range sub.C() {} // never returns

Every open page keeps a stream that receives no more events,
without an error, until the user reloads it.

Close the channel once nats.go closes the subscriptions, after
delivering the messages it holds. The stream ends, the page reconnects,
and the server logs each reconnect that fails on the closed connection.
Require every messaging.Broker to close the channel of a subscription
that can receive no more messages.

Coverage Stats

21 of 23 new or added lines in 1 file covered. (91.3%)

69 existing lines in 4 files now uncovered.

16108 of 36644 relevant lines covered (43.96%)

580.58 hits per line