kubevirt / containerized-data-importer / #6289

50%

Build Type

push

travis-ci

Committed by web-flow

Commit Message

build: Bump to Go 1.26  (#4297)

* build: bump builder image to Go 1.26.8

Signed-off-by: Adi Aloni <aaloni@redhat.com>

* cdi-cloner: use %d for exit code in error message

ExitCode() returns an int, which %q formats as a quoted rune rather
than the number. Go 1.26's printf vet check reports %q on int
arguments, so go test fails for the package once built with Go 1.26.

Signed-off-by: Adi Aloni <aaloni@redhat.com>

* controller: use constant format strings when recording events

Several Eventf calls passed an error message or a pre-formatted string
as the format argument, so any '%'' in it would be misinterpreted. Use
Event for plain messages and pass the format and its arguments directly
otherwise.

Go 1.26's printf vet check reports these as non-constant format strings
when the unit tests run in GOPATH mode, failing the build of the
controller test packages.

Signed-off-by: Adi Aloni <aaloni@redhat.com>

* build: bump Go to 1.26

Signed-off-by: Adi Aloni <aaloni@redhat.com>

---------

Signed-off-by: Adi Aloni <aaloni@redhat.com>

Coverage Stats

4 of 9 new or added lines in 7 files covered. (44.44%)

13 existing lines in 2 files now uncovered.

15454 of 30792 relevant lines covered (50.19%)

0.56 hits per line