Eyevinn / mp4ff / 37210045708

83%

push

github

fix(avc,hevc): drop trailing zero bytes from the last NAL unit of a byte stream

The Annex B extractors removed the zero bytes after every NAL unit except the last one, so trailing_zero_8bits at the end of a stream stayed attached to its last NAL unit. This affected avc.ExtractNalusFromByteStream, avc.GetFirstAVCVideoNALUFromByteStream, and ExtractNalusOfTypeFromByteStream in avc and hevc. Callers that copy NAL unit payloads verbatim had to trim them themselves; hi265's tile stitching does exactly that.

The trim is safe because the last byte of a NAL unit is never 0x00 (H.264 7.4.1, H.265 7.4.2.1). The six copies of the trim loop are replaced by one helper per package, which is also applied to the last NAL unit. As before, the first byte of a NAL unit is always kept.

18 of 18 new or added lines in 2 files covered. (100.0%)

23246 of 28140 relevant lines covered (82.61%)

0.83 hits per line