zostera / django-bootstrap5 / 37204266046

100%

push

github

Remove text_concat (#890)

`django_bootstrap5.text.text_concat` is a general string helper, not a
Bootstrap concern, and nothing in this package has ever called it. Its one
caller joined an icon to a button label in the django-bootstrap4 lineage and
went away in 2017 when icon support was removed, which is before this package
was forked. It was never documented.

Straight removal rather than a deprecation cycle. A GitHub code search finds no
caller anywhere: the only hits outside this repo's own tests are vendored
site-packages copies of `css.py` and `html.py` importing `text_value`, plus an
unrelated reimplementation that carries its own copy. A DeprecationWarning only
pays off if someone sees it, and for a three-line pure function the fix is
cheaper than the warning cycle.

`text_value` stays; `html.py`, `size.py`, `css.py` and `renderers.py` use it.

The smoke test needed a new "one minimal functional call" and now uses
`merge_css_classes`, which is both package-specific and settings-free, matching
how django-marina's smoke test calls `remove_attrs`.

Closes #889.

Co-authored-by: Claude Opus 5 (1M context) <noreply@anthropic.com>

216 of 216 branches covered (100.0%)

Branch coverage included in aggregate %.

705 of 705 relevant lines covered (100.0%)

16.0 hits per line