HSF / phoenix / 37201164873

49%

master: 38%

push

github

fix(event-display): stop animations overriding cut and label visibility (#1038)

Cuts hide objects by setting `visible = false` on the collection's
children (SceneManager.collectionFilter), but `animateEvent` treated that
same flag as animation-owned state: it hid every generic event object at
the start and then unconditionally set `visible = true` once the expanding
animation sphere reached it. Its completion handler calls the update with
a sphere of infinite radius, so *every* cut-hidden object in the event was
forced visible at the end of each animation.

The Cut model itself was never touched, so the menu kept reporting the cut
as active while the scene no longer honoured it. Reported for a 122411 MeV
CaloCluster in CaloCalTopoCluster_xAOD, which reappeared after animating
despite an energy cut that excluded it.

Objects now record whether they were visible before the animation hid
them, and are restored to that state instead of being switched on.

The labels group had the same defect in two places. `animateEvent` hid it
on start and restored it with an unconditional `true`, so animating with
labels toggled off turned them back on; `animateEventWithClipping` hid it
on start and never restored it at all, leaving labels hidden after every
clipping animation. Both now remember and restore the previous state.

Co-authored-by: Claude Opus 5 <noreply@anthropic.com>

906 of 2136 branches covered (42.42%)

Branch coverage included in aggregate %.

6 of 6 new or added lines in 1 file covered. (100.0%)

3386 of 6507 relevant lines covered (52.04%)

203.84 hits per line