HSF / phoenix
49%
master: 38%

LAST BUILD BRANCH: main
DEFAULT BRANCH: master
Repo Added
Files 59
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst

LAST BUILD ON BRANCH main
branch: SELECT
CHANGE BRANCH
x

coverage: 48.9%. Remained the same
35056971269

push

github

web-flow 
fix(ui-components): defer object URL revoke in panel downloads (#1031)

`URL.createObjectURL` hands the browser a handle to the blob, and the anchor
click that follows starts the download asynchronously. Revoking the URL in the
same synchronous task can therefore tear the blob down before the browser has
taken its own reference, cancelling the download.

`saveFile` already defers its revoke to the next tick for exactly this reason,
with a comment saying so. Three UI panels hand-roll the same download instead of
calling it and revoke synchronously:

- kinematics panel "Export TSV"
- masterclass panel "Export results"
- session pill ".phnxreplay" download

The user clicks export and, depending on blob size and browser, either gets the
file or silently gets nothing. Larger exports fail more often, since a bigger
blob gives the browser a wider window in which to lose the race.

PR #992 fixed `saveFile` and stated these call sites "all revoke correctly".
They do revoke, which is why they were passed over, but they revoke in the wrong
task - so the leak was fixed there while this race stayed live here.

Defer the revoke with `setTimeout` in all three, matching `saveFile`. The
kinematics and masterclass anchors are also hidden and removed after the click,
as `saveFile` does, so an unstyled anchor never lands in the layout.

Added tests asserting the URL is not revoked synchronously and is revoked after
the tick. The kinematics and masterclass "not revoked synchronously" cases fail
before this change; the session-pill suite is new.

Fixes #1030

Co-authored-by: Claude Opus 5 <noreply@anthropic.com>

885 of 2131 branches covered (41.53%)

Branch coverage included in aggregate %.

3337 of 6503 relevant lines covered (51.31%)

203.87 hits per line

Relevant lines Covered
6503 RELEVANT LINES 3337 COVERED LINES
203.87 HITS PER LINE
Source Files on master

Recent builds

Builds Branch Commit Type Ran Committer Via Coverage
35056971269 main fix(ui-components): defer object URL revoke in panel downloads (#1031) `URL.createObjectURL` hands the browser a handle to the blob, and the anchor click that follows starts the download asynchronously. Revoking the URL in the same synchronous ta... push web-flow github
48.9
35056838490 main fix(ui-components): report invalid .phnx files instead of failing silently (#1033) `parsePhoenixDisplay` calls `JSON.parse` on the raw file text. It is `async`, so a malformed file surfaces as a rejected promise rather than a synchronous throw, a... push web-flow github
48.9
34966708756 main fix(ui-components): cancel SSMode's deferred listener timer on destroy (#1035) `toggleSSMode` defers attaching the document click/touchstart listeners by 1ms, working around the activating click firing them immediately. The timer id was never sto... push web-flow github
48.9
34966602850 main fix(event-display): keep a cut's default range over clone and save/load (#1037) A Cut captures the bounds it is constructed with as the values `reset()` restores. Both `clone()` and `fromJSON()` rebuild a Cut through that same constructor using i... push web-flow github
48.9
34711053576 main feat(app): hide the menu scrollbar if not needed (#1027) push web-flow github
48.8
34689094615 main chore(release): v4.2.3 push EdwardMoyse github
48.8
34688333979 main feat(event-display): put "Color by" first and color at random from a seed (#1026) The color options menu showed the collection's color swatch and a "Random" button above the "Color by" selector, so the controls for a single color sat outside the ... push web-flow github
48.8
34687884693 main fix(event-display): keep a collection's color over a save and load (#1025) The color of a collection was lost as soon as its state was loaded back. `selectedColorByOption` was initialised to the first color by option, which for tracks is charge, ... push web-flow github
48.72
34687725852 main feat(event-display): put "Color by" first and color at random from a seed The color options menu showed the collection's color swatch and a "Random" button above the "Color by" selector, so the controls for a single color sat outside the mechanis... push EdwardMoyse github
48.8
34687245625 main fix(event-display): keep a collection's color over a save and load (#1025) The color of a collection was lost as soon as its state was loaded back. `selectedColorByOption` was initialised to the first color by option, which for tracks is charge, ... push web-flow github
48.72
See All Builds (1126)