zostera / django-bootstrap3 / 37195016725

100%

push

github

Cover pagination with tests (#1157)

get_pagination_context had no tests at all: 63 statements behind the public
bootstrap_pagination tag, in a package with a lot of users. The tag itself and
bootstrap_url_replace_param were untested too.

24 tests now cover the page window, both clamps, the URL rewriting including
an existing page parameter and a configurable parameter name, the extra
string, the size modifiers, and the two template tags end to end.

Two of those tests started out proving nothing. They were named for the clamp
branches but used inputs that never clamp, and passed anyway. Page 4 of 10
with a window of 5 is what drives pages_back below 1; page 7 is what drives
pages_forward past the last page.

The guard at `if half_page_num < 0` is removed. pages_to_show is coerced with
int() and anything below 1 raises on the line above, so floor(n / 2) cannot be
negative. It was unreachable rather than defensive.

The file goes from 55% to 93%, and the package from 79% to 89%. The rest of
the gap is in utils.py, forms.py and renderers.py, which follow separately.

Co-authored-by: Claude Opus 5 (1M context) <noreply@anthropic.com>

202 of 252 branches covered (80.16%)

Branch coverage included in aggregate %.

686 of 750 relevant lines covered (91.47%)

14.63 hits per line