solidjs / solid / 37185582009

76%

main: 89%

push

github

feat(web): report request failures met before any render (#3763)

* feat(web): report request failures met before any render

Add `reportRequestFailure(error, event)` to the server entry of
`@solidjs/web`, with a no-op in the client view, and `"request"` to
`ServerErrorSite.kind`. A framework's request handler that catches a
failure before any render or server function met it (a middleware
throw) reports it through the ambient server error hook as
`{ kind: "request", handling: "failed", event }`, once per error object,
or to `console.error` when no hook is registered, the same policy as a
render that fails before its shell.

Closes #3723.

* fix(ci): skip size comments for fork pull requests

* feat(web): report synchronous render throws as render/failed before rethrow

A synchronous throw out of renderToString, or out of renderToStream's
first pass (and so renderToFrameStream and serverComponentResponse),
reached the caller without the server error hook hearing it. A request
handler that caught it and called reportRequestFailure filed it as
kind "request". The render now reports it as render/failed through its
own onError or the ambient hook before rethrowing, so the handler's
report of the same error is deduped by the once-per-error ledger. No
console fallback on this road: the rethrow is the caller's.

The "request" kind is documented as a failure that fails the request
outside any render or server function the runtime reports.

Co-authored-by: Claude via Cursor <noreply@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>

* chore(size): raise the renderToString floor cap to 20.42 KB

Measured at 20,412 B against next @ 4738c6dfe's 20,377 (+35 B; +72 B
minified): the catch in renderToString that reports a synchronous throw
as render/failed before rethrowing. Accepted by the maintainer; ledger
note in scripts/size/scenarios.js.

Size-Exception: renderToString reports synchronous render throws as render/failed before rethrowing (+35 B), accep... (continued)

649 of 925 branches covered (70.16%)

Branch coverage included in aggregate %.

962 of 1195 relevant lines covered (80.5%)

27.76 hits per line