solidjs / solid / 37184159737

76%

main: 89%

push

github

fix(web): createSSRResponse tears the render down on body cancel and pre-flush redirect (#3768) (#3772)

The body's cancel() and the pre-flush redirect branch only set a local
`closed` flag, so writes were dropped silently: nothing threw, guardSink
never reached abandon("sink"), and the render kept resolving fragments and
pulling serialized async iterators for nobody.

pipe() now hands the render's teardown to createSSRResponse's sink through
a module-private symbol (the reverse of SHELL_ABANDONED). The body's
cancel() calls it as a "consumer" disconnect, the same reason and finding
as cancelling the readable view; a cancel after end() (queued chunks
draining) is a no-op. A pre-flush redirect tears down quietly, with no
SSR_STREAM_ABANDONED finding, because the response discarded the page
and nobody left. Both settle the render record as "abandoned".

Co-authored-by: Claude via Cursor <noreply@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>

649 of 925 branches covered (70.16%)

Branch coverage included in aggregate %.

962 of 1195 relevant lines covered (80.5%)

27.82 hits per line