php-bug-catcher / bug-catcher / 37185281561

94%

push

github

fix(perf): a machine that cannot measure CPU has no waiting band

The collector omits `u` and `s` where the platform has no getrusage() - which
is every Windows machine - and the aggregator sums what it is given, so those
buckets arrive with `sumUser` and `sumSys` at zero. The report then computed
the waiting band as wallclock minus nothing, and "where the time went" would
have said every Windows request spent 100 % of itself waiting on the database.
That is not a small inaccuracy: it is the most confident wrong answer the
dashboard can give, on the chart whose whole point is finding the database.

`PerfTimePoint::$waitMs` and `TopPathRow::waitMsPerHit()` are now null there.
Not a guess - a PHP request that burned exactly zero microseconds of user
*and* system time does not exist, let alone a whole bucket of them, so zero
across a bucket with traffic can only mean the measurement is missing.

The CPU chart draws nothing for a window with no CPU anywhere, and the panel
says why in words. One bucket that did report is enough to draw it; the rest
contribute nothing to the band rather than all of it.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>

16 of 16 new or added lines in 5 files covered. (100.0%)

3086 of 3276 relevant lines covered (94.2%)

20.83 hits per line