romshark / datapages / 37158800385

44%

Build Type

push

github

Committed by romshark

Commit Message

fix: Resolve href constants at package level

The href lint looks up a bare name in all string constants of the
package, including constants declared inside functions.
When two share a name, the one it uses changes from run to run:

    // app.go
    const LoginURL = "https://example.com/login"

    func fallback() string {
        const LoginURL = "/login"
        return LoginURL
    }

    // app.templ
    <a href={ LoginURL }>Log in</a>

datapages lint passes on some runs and reports "template uses
relative href: /login" on others. Use only package-level constants,
as the spec describes.

Coverage Stats

4 of 4 new or added lines in 1 file covered. (100.0%)

2 existing lines in 1 file now uncovered.

14798 of 36463 relevant lines covered (40.58%)

545.57 hits per line