source-academy / py-slang / 37123180799

86%

push

github

WASM: true division by zero raises ZeroDivisionError (#494)

* WASM: true division by zero raises ZeroDivisionError

`1 / 0` and `1.0 / 0` returned Infinity and `0 / 0` returned NaN in the WASM
engine, where every other engine (and Python) raises ZeroDivisionError.
`//`, `%` and `**` already raised: they are delegated to a host helper that
checks the divisor, but `/` compiles to inline f64.div on three paths with no
check.

Add a zero-divisor check to each: int / int (i64 zero), float / float, which
also covers int / float and float / int after conversion (f64 zero, including
-0.0), and complex / complex (a zero denominator c^2 + d^2). Each logs
ZERO_DIVISION by its static index and traps, like the other inline errors.

Fixes #493

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>

* WASM: test complex divisor components for zero, not c^2+d^2 (underflows)

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>

* Format operators.ts

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>

---------

Co-authored-by: Claude Sonnet 5.5 <noreply@anthropic.com>

4996 of 6252 branches covered (79.91%)

Branch coverage included in aggregate %.

1 of 1 new or added line in 1 file covered. (100.0%)

11181 of 12620 relevant lines covered (88.6%)

171935.53 hits per line