solidjs / solid / 37099202874

76%

main: 89%

push

github

fix(web): a late hydration claim leaves server nodes in place (#3749) (#3760)

* fix(web): a late hydration claim leaves server nodes in place (#3749)

A settled <Loading> whose lazy() module is still loading when hydration
starts returns nothing in the root pass and claims its server nodes on a
later resume. The insert holding the boundary's value sits outside the
boundary: its claim pass saw `undefined` and tracked the region as empty,
so on resume it took the client path (appendNodes / appendChild) and
re-inserted the connected, already-claimed nodes, moving them and
blurring a focused input.

insertExpression now leaves nodes in place when an untracked region
receives nodes already sitting in it in order. The check lives on the
hydration runtime slot, so client-only bundles carry none of it.

Co-authored-by: Claude via Cursor <noreply@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>

* fix(web): shrink the late-claim in-place check (#3749)

One guard at the top of insertExpression replaces the hydration-runtime
helper and its two call sites: an untracked region whose incoming nodes
are all already children of the parent returns without touching the DOM.
The first node rejects a fresh render without allocating. +90 B minified
on hydrating bundles instead of +180, and under every existing cap.

Co-authored-by: Claude via Cursor <noreply@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>

* fix(web): scope the late-claim in-place guard to hydration (#3749)

The guard now runs only while `sharedConfig.hydrating` is set: the root
pass and each boundary's resume window, where the #3749 landing happens.
Then claimed server nodes are the only nodes of ours already in the
parent, so order needs no check. After hydration completes, inserts
behave exactly as on `next`; a new test pins that.

Encoded without the first-node fast path (the allocation is now
hydration-only): +91 B minified on hydrating bundles, under every cap.

Also marks th... (continued)

649 of 925 branches covered (70.16%)

Branch coverage included in aggregate %.

962 of 1195 relevant lines covered (80.5%)

27.9 hits per line