solidjs / solid / 37076935738

76%

main: 89%

push

github

fix(h): materialize elements without mutating the caller's props; correct the render root form (#3756)

* fix(h): materialize elements without mutating the caller's props

An h() element is a thunk that materializes each time its consumer reads
it, but materializing wrote to the caller's props object (children assigned,
zero-arity props turned into getters, class rewritten), so a second
materialization threw — e.g. a Show re-showing a child whose children are
h() elements. Props are now built copy-on-write.

A thunk returned from an accessor child reached insert's inner pass and was
re-created whenever its output changed (a Loading over async children never
settled). It is now materialized in the insert's tracking pass, where JSX
would create the component.

The README's render(() => h(App), el) / render(App, el) root forms hit the
same re-creation through render's insert; it now prescribes render(h(App), el),
and h's call type no longer includes the array passthrough so that form
type-checks.

Co-authored-by: Claude via Cursor <noreply@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>

* docs(h): lead with the render(h(App), el) rule

Co-authored-by: Claude via Cursor <noreply@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>

---------

Co-authored-by: Claude via Cursor <noreply@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>

649 of 925 branches covered (70.16%)

Branch coverage included in aggregate %.

962 of 1195 relevant lines covered (80.5%)

27.63 hits per line