thumbor / thumbor / 37057279867

92%

push

github

fix: limit no_upscale to the cropped and trimmed area

no_upscale() clamped the requested size against the whole source in the
after-load phase, before the transformer applied the manual crop and trim, so
the area left could still be upscaled: 0x0:100x200/full-fit-in/300x400 with
no_upscale() returned 300x600 from image.jpg, and trim/1000x1000 turned the
16x16 trimmed single_point.jpg into 156x42. The filter now only flags the
request, and the Transformer clamps the size against the engine after
reorientation, trim and crop, so the filter no longer needs its own EXIF
orientation swap and the adaptive swap reuses the same limit. orig already
resolved after the crop, so numeric sizes now follow the same rule.

Without a crop or trim the output is unchanged: across fit modes, sizes,
crops, trims and fixtures, every difference from master involves no_upscale
together with a crop or trim, and no output exceeds the cropped or trimmed
area anymore. fill() still pads to the requested canvas. Results already in
result storage keep the old size until they expire, and custom after-load
filters or detectors no longer see the clamped request; none of the built-in
ones read it.

14 of 14 new or added lines in 3 files covered. (100.0%)

4427 of 4833 relevant lines covered (91.6%)

4.58 hits per line