thumbor / thumbor / 37020536760

92%

push

github

fix: drop the query string from the upload Location header

The Location header of an upload was built from the full request URI, so a
POST to /image?foo=bar answered with /image?foo=bar/<id>/<filename>. The
image id and filename ended up inside the query string, and fetching that
location reached the upload handler instead of the image resource, which
answers 405 to a GET. Build the location from the request path instead, so a
query string sent with the upload is left out.

The upload route only matches /image exactly, so requests without a query
string get the same location as before, and the filename stays
percent-encoded.

1 of 1 new or added line in 1 file covered. (100.0%)

4425 of 4836 relevant lines covered (91.5%)

4.58 hits per line