kubeflow / mcp-server / 37053472487
83%

DEFAULT BRANCH: main
Ran
Jobs 3
Files 38
Run time 1min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst
coverage: 81.929% (+0.02%) from 81.905%
37053472487

push

github

web-flow 
fix: use VALIDATION_ERROR for invalid model ID in estimate_resources (#258)

* fix(trainer): use VALIDATION_ERROR for invalid model ID in estimate_resources

estimate_resources() returned SDK_ERROR for invalid model ID formats, causing AI agents to retry the same bad input. Now returns VALIDATION_ERROR for format errors while preserving SDK_ERROR for actual API/network failures.

Closes #257

Signed-off-by: pratik naik <naikp0241@gmail.com>

* fix(trainer): treat nonexistent model IDs as VALIDATION_ERROR

Per review, a well-formed but nonexistent model ID (RepositoryNotFoundError)
still returned SDK_ERROR because the check matched the "Invalid" message
prefix. It is a user-input error too, and already gets "did you mean"
suggestions.

Have _get_model_info_from_hf() tag input errors with an explicit kind
("format" or "not_found") and map those to VALIDATION_ERROR in
estimate_resources(), instead of matching message text. API/network
failures stay SDK_ERROR. Add a regression test for the not-found case.

Signed-off-by: pratik naik <naikp0241@gmail.com>

* fix(trainer): keep SDK_ERROR for inaccessible HuggingFace repos

Per review, RepositoryNotFoundError is not only raised for a nonexistent
repo: the Hub also raises it for private or gated repos and missing auth
(401, and GatedRepoError which subclasses it). Mapping all of those to
VALIDATION_ERROR would report an access failure as bad input.

Tag the error as "not_found" only for a plain 404 that is not a
GatedRepoError. Other cases keep SDK_ERROR. Add regression tests for the
401 and gated cases.

Signed-off-by: pratik naik <naikp0241@gmail.com>

* fix(trainer): narrow the not-found contract to confirmed 404s

Per review: the Hub answers an anonymous request for a missing model with
401, the same as for a private repo, so the two cannot be told apart and a
401 must not be classified as bad input.

Narrow the documented contract: VALIDATION_ERROR is returned for a
malformed model ID and for a repo the ... (continued)

2489 of 3038 relevant lines covered (81.93%)

2.46 hits per line

Coverage Regressions

Lines Coverage ∆ File
127
36.07
0.93% trainer/api/planning.py
Jobs
ID Job ID Ran Files Coverage
1 python-3.10 - 37053472487.1 38
81.93
GitHub Action Run
2 python-3.12 - 37053472487.2 38
81.93
GitHub Action Run
3 python-3.11 - 37053472487.3 38
81.93
GitHub Action Run
Source Files on build 37053472487