romshark / datapages / 37042520297

44%

Build Type

push

github

Committed by romshark

Commit Message

fix: Refuse subject fields that misroute events

- fix: Refuse a second datapages.SubjectUser field on an event in
  datapages lint and gen. A stream subscribes by one user position,
  the first one:

      // EventDMed is "dmed"
      type EventDMed struct {
          To, Cc datapages.SubjectUser

          Text string `json:"text"`
      }

  Dispatching EventDMed{To: "alice", Cc: "bob"} publishes to
  dmed.alice.bob, but every stream subscribes to dmed.<user>.*. Bob
  never receives the event, and alice receives it whatever Cc holds.

- fix: Refuse an event field whose type holds datapages.SubjectUser,
  datapages.Subject or datapages.SubjectStateID in a slice, array, map,
  pointer or channel. Such a field looks like a list of recipients but
  is a payload field, which leaves the event without the segment:

      // EventDirectMessage is "dm"
      type EventDirectMessage struct {
          Recipients []datapages.SubjectUser `json:"recipients"`

          Text string `json:"text"`
      }

  EventDirectMessage has no subject field. Dispatching it publishes to
  dm, and every stream of a page handling it receives the message,
  not only the listed recipients. Rewrite the Dispatcher example to
  dispatch once per participant instead of setting
  Recipients: room.ParticipantIDs.

Coverage Stats

33 of 79 new or added lines in 5 files covered. (41.77%)

20 existing lines in 3 files now uncovered.

14722 of 36330 relevant lines covered (40.52%)

543.92 hits per line