romshark / datapages / 37032967133

44%

Build Type

push

github

Committed by romshark

Commit Message

fix: Recover panics on anonymous streams

Recover a panic in an OnXXX handler on the stream that a page with
both public and user-addressed events serves to signed-out visitors,
as the stream of signed-in visitors does. Take this page:

    // PageRoom is /room
    type PageRoom struct{ App *App }

    // Public: EventPosted has no SubjectUser field.
    func (PageRoom) OnPosted(e EventPosted, sse datapages.SSE) error

    // Private: EventNoticed has a SubjectUser field.
    func (PageRoom) OnNoticed(e EventNoticed, sse datapages.SSE) error

A guest's stream at /room/_$/anon/ runs OnPosted outside any recover.
A panic there drops the connection, never reaches RecoverError and
skips StreamClose, which leaks the per-tab state that StreamOpen holds.

Run the close hook in a defer once StreamOpen succeeds, which keeps
StreamClose paired with StreamOpen for any panic out of
the message loop.

Coverage Stats

7 of 7 new or added lines in 2 files covered. (100.0%)

2 existing lines in 1 file now uncovered.

14686 of 36253 relevant lines covered (40.51%)

544.74 hits per line