urwid / urwid / 37028965609

90%

push

github

End OSC strings at ESC not followed by backslash (#1392)

Both OSC parsers kept an ESC inside an OSC string when it did not start
the ST terminator, so the following escape sequences and text were
swallowed into the string, and could end up in the window title.
ECMA-48 allows no ESC in a command string other than in ST, so they now
end the string there.

- AnsiParser records the unterminated OSC as skipped, never as a title,
  then parses the ESC as the start of a new escape sequence.
- The same applies to the discarded rest of an over-long OSC string.
- vterm TermCanvas drops the unterminated OSC and parses the ESC as the
  start of a new escape sequence.

4661 of 5594 branches covered (83.32%)

Branch coverage included in aggregate %.

12 of 12 new or added lines in 2 files covered. (100.0%)

11663 of 13292 relevant lines covered (87.74%)

9.81 hits per line