urwid / urwid / 37028107012

90%

push

github

Free runtime signal classes; keep weak disconnects (#1391)

The signal registry kept every class with signals alive, and a weak
argument's callback could have its disconnect undone by the connect
or disconnect it interrupted.

- Signals keys its registry of supported signals weakly, so classes
  created at run time are collected.
- connect and disconnect_by_key drop handlers with a dead weak
  argument after writing, so a callback run between their read and
  write cannot leave its handler connected.
- The weak-argument callback tests the emitter reference against
  None, so a handler on a falsy emitter, such as an empty
  SimpleListWalker, is removed when its weak argument dies.

4652 of 5588 branches covered (83.25%)

Branch coverage included in aggregate %.

7 of 7 new or added lines in 1 file covered. (100.0%)

11647 of 13280 relevant lines covered (87.7%)

9.8 hits per line